-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Elyra to Kfp v2 #3219
base: main
Are you sure you want to change the base?
Migrate Elyra to Kfp v2 #3219
Conversation
chore: bump version of kfp sdk
@@ -729,7 +704,7 @@ | |||
pipeline.pipeline_properties.get(pipeline_constants.COS_OBJECT_PREFIX), pipeline_instance_id | |||
) | |||
# - load the generic component definition template | |||
template_env = Environment(loader=PackageLoader("elyra", "templates/kubeflow/v1")) | |||
template_env = Environment(loader=PackageLoader("elyra", "templates/kubeflow/v2")) |
Check warning
Code scanning / CodeQL
Jinja2 templating with autoescape=False Medium
Signed-off-by: Harshad Reddy Nalla <[email protected]>
Cap kfp version for avoiding protobuf version dependency
fix: update container properties according to kfpv2
fix: remove helper method to set image pull policy
fix: remove helper methods for adding toleration
Any update here? |
Working on it , will require some more time to finish this. |
Hi, can I ask when will this PR be released? |
@harshad16 are you still working on this PR? If you don't have time now, maybe I could wrap everything we have on ODH into a new PR. Please let me know. @lresende do you want to include this code to |
If we have KFP v2 working fine, it would be great... |
Kfpv2 is working in https://github.com/opendatahub-io/elyra/tree/kfpv2, what remains is to merge the changes back here I'm mentioning it here since apparently there seems to be renewed interest in the PR. |
See #3273 |
What changes were proposed in this pull request?
Support for kfp v2.
This PR removed
kfp-tekton
from dependencies and allows only Argo to be used as controller runtime engine.Related-to:
#1930
#2918
How was this pull request tested?
To test this PR:
make clean install
at the root. This should install elyra-server and jupyter extensions.Developer's Certificate of Origin 1.1